Details

I think the version should be 2.4.1 not 2.4.1.0 and component maybe it is better programming.library.
You can add the homepage too. https://www.libvolk.org/.

added homepage, shortend version number, changed component

Otherwise LGTM :) You'll also need to add this as a dependency of your gnuradio package. In your summary for the gnuradio package, end it with (like on a new line): Depends on D10458

package.yml
12	Should be before component preferably
20	Trailing newline should be removed.

This revision now requires changes to proceed.Feb 5 2021, 6:54 AM

changed order, and it is listed as dependencie of gnuradio

LGTM, thanks!

This revision is now accepted and ready to land.Feb 11 2021, 8:12 AM

Correction, also needs a MAINTAINERS.md file containing the following contents, replacing the relevant sections.

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- REPLACEME FIRST NAME(S) LAST NAME(S)
  - IRC: REPLACEME
  - Email: REPLACEME

This revision now requires changes to proceed.Feb 11 2021, 8:17 AM

Added Mainteiners.md
What does LGTM mean? :D

LGTM means looks good to me.

This revision is now accepted and ready to land.Mar 6 2021, 4:05 PM

Closed by commit R5164:9733f2940105: initial inclusion of volk (authored by VValterKing, committed by JoshStrobl). · Explain WhyMar 6 2021, 4:06 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5164:9733f2940105: initial inclusion of volk.

initial inclusion of volk
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25682

MAINTAINERS.md

abi_symbols

abi_used_libs

package.yml

pspec_x86_64.xml

initial inclusion of volkClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25682

MAINTAINERS.md

abi_symbols

abi_used_libs

package.yml

pspec_x86_64.xml

initial inclusion of volk
ClosedPublic
Actions

Revision Contents
Changeset List