Page MenuHomeSolus

initial inclusion of volk
ClosedPublic

Authored by VValterKing on Jan 30 2021, 12:37 PM.

Details

Summary

VOLK is the Vector-Optimized Library of Kernels

Test Plan

It is working in local repo to build gnuradio

Diff Detail

Repository
R5164 volk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

VValterKing created this revision.Jan 30 2021, 12:37 PM
VValterKing requested review of this revision.Jan 30 2021, 12:37 PM
Girtablulu retitled this revision from Inclusion of volk as Dependency for Gnuradio D9163 to initial inclusion of volk.Jan 30 2021, 1:15 PM
algent added a subscriber: algent.Jan 30 2021, 1:16 PM

I think the version should be 2.4.1 not 2.4.1.0 and component maybe it is better programming.library.
You can add the homepage too. https://www.libvolk.org/.

added homepage, shortend version number, changed component

JoshStrobl requested changes to this revision.Feb 5 2021, 6:54 AM
JoshStrobl added a subscriber: JoshStrobl.

Otherwise LGTM :) You'll also need to add this as a dependency of your gnuradio package. In your summary for the gnuradio package, end it with (like on a new line): Depends on D10458

package.yml
12

Should be before component preferably

20

Trailing newline should be removed.

This revision now requires changes to proceed.Feb 5 2021, 6:54 AM
VValterKing updated this revision to Diff 25331.Feb 9 2021, 5:37 PM

changed order, and it is listed as dependencie of gnuradio

JoshStrobl accepted this revision.Feb 11 2021, 8:12 AM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 11 2021, 8:12 AM
JoshStrobl requested changes to this revision.Feb 11 2021, 8:17 AM

Correction, also needs a MAINTAINERS.md file containing the following contents, replacing the relevant sections.

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- REPLACEME FIRST NAME(S) LAST NAME(S)
  - IRC: REPLACEME
  - Email: REPLACEME
This revision now requires changes to proceed.Feb 11 2021, 8:17 AM

Added Mainteiners.md
What does LGTM mean? :D

JoshStrobl accepted this revision.Mar 6 2021, 4:05 PM

LGTM means looks good to me.

This revision is now accepted and ready to land.Mar 6 2021, 4:05 PM
This revision was automatically updated to reflect the committed changes.