Page MenuHomeSolus
Differential D10453

Update qutebrowser to 2.0.2
ClosedPublic
Actions

Authored by Phantop on Jan 28 2021, 5:59 PM.
Tags
None
Referenced Files
F10809018: D10453.id25177.diff
Tue, May 30, 11:35 AM
F10808997: D10453.id25487.diff
Tue, May 30, 11:28 AM
F10808942: D10453.id25175.diff
Tue, May 30, 11:13 AM
F10808124: D10453.id25176.diff
Tue, May 30, 7:18 AM
F10807719: D10453.id25674.diff
Tue, May 30, 5:55 AM
F10764371: D10453.id.diff
Fri, May 19, 6:42 AM
F10751163: D10453.id25674.diff
Tue, May 16, 10:59 AM
F10746627: D10453.diff
Mon, May 15, 11:55 AM
View All 11 Files
Subscribers
algent
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R2776:e99c54ef6f50: Update qutebrowser to 2.0.2
Summary

Major changes

  • Removes a number of dependencies
  • Requires a newer version of python-importlib-resources than currently packaged.
  • Adds in a new adblocker (python-adblock, currently not packaged in Solus)

Changelog:

Depends on D10452

Test Plan

Launch the browser, visit dev.getsol.us, and launch the qr userscript

Diff Detail

Repository
R2776 qutebrowser
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Phantop created this revision.Jan 28 2021, 5:59 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptJan 28 2021, 5:59 PM
Phantop requested review of this revision.Jan 28 2021, 5:59 PM
Phantop updated this revision to Diff 25176.Jan 28 2021, 6:26 PM

Remove pygments, as it is an optional dependency for the webkit backend

algent added a subscriber: algent.Jan 28 2021, 6:48 PM

You can remove python-markupsafe because it is a dependency for python-jinja.

algent added a comment.Jan 28 2021, 6:50 PM

Since you updated also python-importlib-resources you can add it as stack for qutebrowser update.

Phantop updated this revision to Diff 25177.Jan 28 2021, 6:51 PM

Remove redundant python-markupsafe

Phantop added a comment.Jan 28 2021, 6:51 PM
In D10453#172064, @algent wrote:

Since you updated also python-importlib-resources you can add it as stack for qutebrowser update.

I don't know how to do this...

algent added a comment.Jan 28 2021, 7:03 PM

I don't know how to do this...

That is easy. Edit your SUMMARY: and add a new line Depends on D10452.

See this diff for example https://dev.getsol.us/D10429.

Phantop edited the summary of this revision. (Show Details)Jan 28 2021, 7:04 PM
Phantop added a parent revision: D10452: Update python-importlib-resources to 3.3.1.
Phantop edited the summary of this revision. (Show Details)
JoshStrobl edited the summary of this revision. (Show Details)Feb 2 2021, 7:03 AM
JoshStrobl accepted this revision.Feb 2 2021, 7:05 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Feb 2 2021, 7:05 AM
Phantop updated this revision to Diff 25487.EditedFeb 19 2021, 10:59 PM

Update qutebrowser to 2.0.2
Seeing as this diff hasn't been accepted yet, here's 2.0.2.
python-importlib-resources is also awaiting review so everything is done on my end.

Phantop retitled this revision from Update qutebrowser to 2.0.1 to Update qutebrowser to 2.0.2.Feb 19 2021, 10:59 PM
Phantop edited the summary of this revision. (Show Details)
JoshStrobl added a comment.Mar 6 2021, 2:58 PM

LGTM, sorry I meant to land this much earlier.

Closed by commit R2776:e99c54ef6f50: Update qutebrowser to 2.0.2 (authored by Phantop, committed by JoshStrobl). · Explain WhyMar 6 2021, 2:58 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R2776:e99c54ef6f50: Update qutebrowser to 2.0.2.

Revision Contents
Changeset List

PathSize
12 lines
66 lines

Diff 25674

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.