Details

Reviewers

JoshStrobl
joebonrichie

Group Reviewers

Triage Team

Commits

R4841:166ddd5b6b81: Update python-importlib-resources to 3.3.1

Summary

Backports importlib.resources from Python 3.9 rather than 3.6. Official changelog here.

Newer version is required for qutebrowser 2.0.1. Latest version is 5.1.0, but drops Python 2 support so this patch only updates to 3.3.1.

Test Plan

Install this package, qutebrowser, docker-compose, anki, and spyder3. Make sure all packages function correctly by launching them.

Diff Detail

Repository

R4841 python-importlib-resources

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Phantop created this revision.Jan 28 2021, 5:55 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 28 2021, 5:55 PM

Phantop requested review of this revision.Jan 28 2021, 5:55 PM

I was unsure about which packages depend on this. If the Python 2 support is unneeded, let me know and I'll update this to the latest version.

Phantop edited the summary of this revision. (Show Details)Jan 28 2021, 6:02 PM

Phantop edited the summary of this revision. (Show Details)

Phantop edited the summary of this revision. (Show Details)Jan 28 2021, 6:05 PM

Phantop added a child revision: D10453: Update qutebrowser to 2.0.2.Jan 28 2021, 7:04 PM

In D10452#172049, @Phantop wrote:

I was unsure about which packages depend on this.

anki, docker-compose, and spyder3 to name a few.

package.yml
22	Has trailing whitespace that should be removed.

Remove trailing whitespace

Remove other trailing whitespace

Marking as requesting changes pending validation of anki and spyder3 at the very least. Otherwise LGTM.

This revision now requires changes to proceed.Feb 2 2021, 7:05 AM

Phantop edited the test plan for this revision. (Show Details)Feb 2 2021, 4:00 PM

In D10452#172693, @JoshStrobl wrote:

Marking as requesting changes pending validation of anki and spyder3 at the very least. Otherwise LGTM.

I've actually been using docker-compose with this installed for a while so I can confirm that's working without issue. Installed anki and spyder3 and both launched without issue, no noticeable problems after using them for a few minutes. If there's anything further required to test them let me know and I'll get right on it, but everything seems good.

Test plan changed and all the mentioned applications appear to work without issue. Didn't realize that I had to do a proper Arcanist diff for this so here ya go.

joebonrichie mentioned this in R4545:0a2efca83981: Readd python2 support for D10452.Feb 20 2021, 8:26 AM

joebonrichie accepted this revision.Mar 3 2021, 10:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 3 2021, 10:19 PM

Closed by commit R4841:166ddd5b6b81: Update python-importlib-resources to 3.3.1 (authored by Phantop, committed by joebonrichie). · Explain Why

This revision was automatically updated to reflect the committed changes.

joebonrichie added a commit: R4841:166ddd5b6b81: Update python-importlib-resources to 3.3.1.