Page MenuHomeSolus

Update python-importlib-resources to 3.3.1
ClosedPublic

Authored by Phantop on Jan 28 2021, 5:55 PM.

Details

Summary

Backports importlib.resources from Python 3.9 rather than 3.6. Official changelog here.

Newer version is required for qutebrowser 2.0.1. Latest version is 5.1.0, but drops Python 2 support so this patch only updates to 3.3.1.

Test Plan

Install this package, qutebrowser, docker-compose, anki, and spyder3. Make sure all packages function correctly by launching them.

Diff Detail

Repository
R4841 python-importlib-resources
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Phantop created this revision.Jan 28 2021, 5:55 PM
Phantop requested review of this revision.Jan 28 2021, 5:55 PM
Phantop added a comment.EditedJan 28 2021, 5:56 PM

I was unsure about which packages depend on this. If the Python 2 support is unneeded, let me know and I'll update this to the latest version.

Phantop edited the summary of this revision. (Show Details)Jan 28 2021, 6:02 PM
Phantop edited the summary of this revision. (Show Details)
Phantop edited the summary of this revision. (Show Details)Jan 28 2021, 6:05 PM

I was unsure about which packages depend on this.

anki, docker-compose, and spyder3 to name a few.

package.yml
22

Has trailing whitespace that should be removed.

Phantop updated this revision to Diff 25202.Jan 29 2021, 7:58 PM

Remove trailing whitespace

Phantop updated this revision to Diff 25203.Jan 29 2021, 7:59 PM

Remove other trailing whitespace

JoshStrobl requested changes to this revision.Feb 2 2021, 7:05 AM

Marking as requesting changes pending validation of anki and spyder3 at the very least. Otherwise LGTM.

This revision now requires changes to proceed.Feb 2 2021, 7:05 AM
Phantop edited the test plan for this revision. (Show Details)Feb 2 2021, 4:00 PM
Phantop marked an inline comment as done.Feb 2 2021, 4:04 PM

Marking as requesting changes pending validation of anki and spyder3 at the very least. Otherwise LGTM.

I've actually been using docker-compose with this installed for a while so I can confirm that's working without issue. Installed anki and spyder3 and both launched without issue, no noticeable problems after using them for a few minutes. If there's anything further required to test them let me know and I'll get right on it, but everything seems good.

Phantop updated this revision to Diff 25328.EditedFeb 8 2021, 12:51 AM

Test plan changed and all the mentioned applications appear to work without issue. Didn't realize that I had to do a proper Arcanist diff for this so here ya go.

joebonrichie accepted this revision.Mar 3 2021, 10:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 3 2021, 10:19 PM
This revision was automatically updated to reflect the committed changes.