Backports importlib.resources from Python 3.9 rather than 3.6. Official changelog here.
Newer version is required for qutebrowser 2.0.1. Latest version is 5.1.0, but drops Python 2 support so this patch only updates to 3.3.1.
Details
Details
- Reviewers
JoshStrobl joebonrichie - Group Reviewers
Triage Team - Commits
- R4841:166ddd5b6b81: Update python-importlib-resources to 3.3.1
Install this package, qutebrowser, docker-compose, anki, and spyder3. Make sure all packages function correctly by launching them.
Diff Detail
Diff Detail
- Repository
- R4841 python-importlib-resources
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I was unsure about which packages depend on this. If the Python 2 support is unneeded, let me know and I'll update this to the latest version.
Comment Actions
anki, docker-compose, and spyder3 to name a few.
| package.yml | ||
|---|---|---|
| 22 | Has trailing whitespace that should be removed. | |
Comment Actions
Marking as requesting changes pending validation of anki and spyder3 at the very least. Otherwise LGTM.
Comment Actions
I've actually been using docker-compose with this installed for a while so I can confirm that's working without issue. Installed anki and spyder3 and both launched without issue, no noticeable problems after using them for a few minutes. If there's anything further required to test them let me know and I'll get right on it, but everything seems good.
Comment Actions
Test plan changed and all the mentioned applications appear to work without issue. Didn't realize that I had to do a proper Arcanist diff for this so here ya go.