Page MenuHomeSolus

Update PHP to 7.4.16
ClosedPublic

Authored by kaktuspalme on Jan 25 2021, 5:44 PM.

Details

Summary

Updates PHP to 7.4.16. Changelog

Test Plan

arc diff
xdebug
phoronix test suite
checked php-fpm service

Diff Detail

Repository
R2424 php
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kaktuspalme created this revision.Jan 25 2021, 5:44 PM
kaktuspalme requested review of this revision.Jan 25 2021, 5:44 PM
kaktuspalme edited the test plan for this revision. (Show Details)Jan 25 2021, 6:35 PM
kaktuspalme edited the test plan for this revision. (Show Details)Jan 25 2021, 6:38 PM
kaktuspalme updated this revision to Diff 25154.EditedJan 25 2021, 7:32 PM
  • uses external gdlib, removes unneded white spaces, removes unused build deps
JoshStrobl requested changes to this revision.Feb 2 2021, 7:11 AM
JoshStrobl added a subscriber: JoshStrobl.

You should also be using on the parent / child revision functionality in Phabricator under the Edit Related Revisions or alternatively using Depends on DNNNN in the other revisions to indicate what software PHP is required for, rather than referencing in the test plan.

package.yml
69

Should be after --with-enchant=shared \

77–78

It's no longer using our freetype per the abi_used_libs. Should be looked into.

82–83

It's no longer using our libjpeg per the abi_used_libs. Should be looked into.

99–100

You're building with webp but it gets dropped per the abi_used_libs. May be worth looking into.

103

It's no longer using our libpng per the abi_used_libs. Should be looked into.

This revision now requires changes to proceed.Feb 2 2021, 7:11 AM

Removed unused configure options

kaktuspalme retitled this revision from Update PHP to 7.4.14 to Update PHP to 7.4.15.Feb 15 2021, 4:18 PM
kaktuspalme edited the summary of this revision. (Show Details)
kaktuspalme edited the test plan for this revision. (Show Details)
kaktuspalme marked 4 inline comments as done.Feb 15 2021, 4:24 PM
kaktuspalme added inline comments.
package.yml
69

I reordered all configure options

77–78

Thanks for pointing that out. I had to look at the configure options. With the --with-external-gd these options don't do anything as php uses the libgd from the system and not the bundled one. Therefore there's no direct dependency anymore on these libs, only an indirect dependency via libgd.
This applies to webp, jpeg, freetype and xpm.

kaktuspalme planned changes to this revision.Feb 15 2021, 4:28 PM
kaktuspalme marked 2 inline comments as done.
This comment was removed by kaktuspalme.
kaktuspalme requested review of this revision.Feb 15 2021, 4:38 PM
kaktuspalme planned changes to this revision.Feb 16 2021, 6:06 AM

There are more configuration options which do nothing, will go through them and change that.

kaktuspalme updated this revision to Diff 25438.EditedFeb 17 2021, 3:41 PM

Updated php.ini-production to the one provided by php and adjusted the settings
Removed configure options which don't exist anymore / are enabled by default
Added sodium extension
Added abi_symbols file

kaktuspalme marked an inline comment as done.Feb 17 2021, 3:43 PM
kaktuspalme edited the test plan for this revision. (Show Details)Feb 17 2021, 4:06 PM
JoshStrobl requested changes to this revision.Feb 17 2021, 4:56 PM

Otherwise LGTM.

pspec_x86_64.xml
30–31

Is /usr/lib64/build used for anything by PHP? If not, maybe worth nuking.

This revision now requires changes to proceed.Feb 17 2021, 4:56 PM
kaktuspalme marked an inline comment as done.Feb 17 2021, 5:16 PM
kaktuspalme added inline comments.
pspec_x86_64.xml
30–31

I was unsure about that too. phpize needs it, xdebug for example can't be built without phpize.

kaktuspalme marked an inline comment as done.Feb 17 2021, 5:16 PM
kaktuspalme requested review of this revision.Feb 17 2021, 5:21 PM
JoshStrobl added inline comments.Mar 6 2021, 3:02 PM
pspec_x86_64.xml
30–31

Would it be possible to maybe change it? If it's too cumbersome, that's fine, I was just curious if we could throw it somewhere like /usr/lib64/php/build is all.

SaxJ awarded a token.Mar 7 2021, 2:46 PM
SaxJ added a subscriber: SaxJ.

Update to PHP 7.4.16, move phpize and /usr/lib64/build to devel package

kaktuspalme retitled this revision from Update PHP to 7.4.15 to Update PHP to 7.4.16.Thu, Mar 25, 8:06 AM
kaktuspalme edited the summary of this revision. (Show Details)
kaktuspalme marked an inline comment as done.Thu, Mar 25, 8:09 AM
kaktuspalme added inline comments.
pspec_x86_64.xml
30–31

Unfortunately there's no configure switch to build that. In the generated Makefile the path is hardcoded to {libdir}/build. But the files are not necessary to use PHP therefore I moved them to the -devel package.

kaktuspalme marked an inline comment as done.Thu, Mar 25, 9:31 AM
JoshStrobl accepted this revision.Sat, Apr 10, 12:36 PM

Well LGTM, thanks!

This revision is now accepted and ready to land.Sat, Apr 10, 12:36 PM
This revision was automatically updated to reflect the committed changes.