Page MenuHomeSolus

Re-add VDPAU for nvidia proprietary blob
AbandonedPublic

Authored by joebonrichie on Jan 22 2021, 10:36 AM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

R3140:99d8cc7ddccd removed support as it mentioned that the mesa implementation of vdpau is buggy. However, vpdau is primarily providided for the nvidia driver which doesn't support VA-API. Mesa clients should use VA-API.

Signed-off-by: Joey Riches <josephriches@gmail.com>

Test Plan

Play a youtube video and confirm and confirm vdpau was working.

Diff Detail

Repository
R3140 vlc
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

joebonrichie created this revision.Jan 22 2021, 10:36 AM
joebonrichie requested review of this revision.Jan 22 2021, 10:36 AM

I would be open to discussing dropping vdpau from mesa instead however, consideration will need to be made to whether steam or any games use vdpau in some way.

Per my commit and per the statement by one of the VLC developers, the "Mesa VDPAU driver is notoriously buggy". The original ticket was filed and closed with no resolution, when VDPAU was the clear issue, with our forum discussion being here. VLC continues to function perfectly fine when the user has NVIDIA proprietary drivers, I would not made those changes if it wasn't the case.

VLC continues to function perfectly fine when the user has NVIDIA proprietary drivers

Yes, but our VLC build can't use hardware decoding on Nvidia, since VLC as of now doesn't support Nvidia Codec (this will come only with VLC 4). Currently users of VLC and Nvidia GPUs are left only with software decoding.
I don't really care about VDPAU support since I use AMD, but I think some users might want to use VLC with hwdec on Nvidia, so I think we should provide VDPAU support for them. And we can drop it in favor of nvcodec whenever VLC 4 comes.

And yet it works and doesn't result in breakages for other users. If there is a proposal and patch provided besides just re-enabling it, e.g. having other decoding methods has precedent, I'm interested. Until then, I'm not.

JoshStrobl abandoned this revision.Sun, Jan 31, 10:06 AM