Page MenuHomeSolus

Update arcanist to 2020.10.19
ClosedPublic

Authored by kaktuspalme on Jan 17 2021, 11:00 AM.

Details

Summary

Updates arcanist to 2020.10.19

Test Plan

arc diff

Diff Detail

Repository
R375 arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kaktuspalme created this revision.Jan 17 2021, 11:00 AM
kaktuspalme requested review of this revision.Jan 17 2021, 11:00 AM
kaktuspalme planned changes to this revision.Jan 17 2021, 11:01 AM
This comment was removed by kaktuspalme.
kaktuspalme requested review of this revision.Jan 25 2021, 8:08 AM

I only had to change one patch. It affects arc land. Arc land is heavily changed and I think I can't test it without an own phabricator instance somewhere. So I would be happy if somebody can test if arc land still does what it should do.

JoshStrobl requested changes to this revision.Feb 2 2021, 7:14 AM
JoshStrobl added a subscriber: JoshStrobl.

Diff seems botched. The full diff now is https://dev.getsol.us/file/data/ayaxm5gm5xko4zigumpn/PHID-FILE-cu7v6uhglevcfiyle7al/files_0001-Remove-author-revision-prompt-since-our-use-of-Arcan.patch and doesn't seem to have the modifications of the second file.

package.yml
12

Can this be removed? No details are provided in the changelog as packager notes.

13

Trailing whitespace.

This revision now requires changes to proceed.Feb 2 2021, 7:14 AM
kaktuspalme marked an inline comment as done.Feb 15 2021, 3:47 PM
kaktuspalme added inline comments.
kaktuspalme marked an inline comment as done.

Remove trailing whitespace

kaktuspalme marked an inline comment as done.Feb 15 2021, 3:50 PM

Add patch regarding unauthored revisions in arc land

JoshStrobl accepted this revision.Feb 17 2021, 4:58 PM

LGTM, can validate arc patch + landing procedure after this lands :)

This revision is now accepted and ready to land.Feb 17 2021, 4:58 PM
This revision was automatically updated to reflect the committed changes.