Page MenuHomeSolus

Inclusion of protonmail-bridge resolves T8937
ClosedPublic

Authored by FriesischScott on Jan 12 2021, 12:21 PM.

Details

Summary

Replaces D9816 due to lack of progress.

I have a ProtonMail subscription and would like to maintain this.

ProtonMail Bridge requires either gnome-keyring or pass but will default to pass if both are installed. Should I add a rundep on either?

Test Plan

Installed and configured the bridge. Works flawlessly with Thunderbird.

Diff Detail

Repository
R5138 protonmail-bridge
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

FriesischScott requested review of this revision.Jan 12 2021, 12:21 PM
JoshStrobl requested changes to this revision.Jan 15 2021, 9:04 AM
JoshStrobl added a subscriber: JoshStrobl.

I imagine gnome-keyring is the more likely password daemon to be used on the system, so let's go with that.

Great work improving on the previous patch. Are all the missing libs intentionally omitted, no longer necessary, or some other reason?

package.yml
17

builddeps should be:

  1. pkgconfigs first, alphabetically ordered 0-9A-Za-z
  2. "explicitly named deps" alphaebetically ordered, like git and golang.
24

Unnecessary empty line.

26

Unnecessary empty line.

This revision now requires changes to proceed.Jan 15 2021, 9:04 AM

Sort builddeps and remove empty lines

Add rundep on gnome-keyring.

The github repository contains two apps. The bridge and an import-export app. The releases have since been split to contain the individual apps prefixed by br- and ie-. I assume the extra libs in D9816 are dependencies of the import-export app.

Something is missing. The build doesn't seem to pick up all necessary Qt5 dependencies. I just tried to install and run my package on a fresh install of Budgie (I was on Plasma before) and it doesn't work. I'll update this once I figured it out.

Add missing rundep on qt5-quickcontrols2

JoshStrobl accepted this revision.Jan 20 2021, 5:04 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 20 2021, 5:04 PM