Page MenuHomeSolus

Rebuild blender against recent updates
ClosedPublic

Authored by YakoYakoYokuYoku on Tue, Jan 12, 4:22 AM.

Details

Summary

Depends on D10339, D10341, D10345, D10346, D10349 and D10360.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Rendered a 3D scene in this program.

Diff Detail

Repository
R437 blender
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Tue, Jan 12, 4:22 AM
aleksvor added inline comments.
package.yml
59

Can you look into turning off this option? As I see, it only makes Blender dynamically load libSDL instead of just statically linking it like all other libraries. I think there are no benefits of dynamic loading for us, since we always can rebuild Blender in case of binary incompatibilities (and SDL2 already does great job at keeping ABI stable).

Add potrace update as dependency.

YakoYakoYokuYoku edited the summary of this revision. (Show Details)Tue, Jan 12, 1:44 PM
YakoYakoYokuYoku marked an inline comment as done.
kyrios123 added inline comments.
package.yml
43

fwiw, I am pushing a new version of pugixml that now provides pkgconfig(pugixml)

YakoYakoYokuYoku marked an inline comment as done.
YakoYakoYokuYoku edited the summary of this revision. (Show Details)

libusd as dependency.

ermo awarded a token.Thu, Jan 14, 1:12 AM
ermo added a subscriber: ermo.Thu, Jan 14, 1:16 AM

As a sign of intent, I think it would be good to explicitly enable the new cmake configuration options that correspond to the new deps you're adding during the setup phase with this update?

This also serves as control that you've actually read the cmake build file and checked out the available options there (in my experience, this is the smart thing to do).

ermo requested changes to this revision.Thu, Jan 14, 1:17 AM
This revision now requires changes to proceed.Thu, Jan 14, 1:17 AM

Include the CMake configurations and add homepage.

YakoYakoYokuYoku edited the summary of this revision. (Show Details)

Add dependency on openimagedenoise update.

JoshStrobl accepted this revision.Wed, Jan 20, 2:36 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jan 20, 4:18 AM
This revision was automatically updated to reflect the committed changes.