SBT released version 1.0.2. Removed a jvm argument that made the JVM
print an error message each time the sbt script was run.
Signed-off-by: René Vangsgaard <rene.vangsgaard@gmail.com>
Details
Details
- Reviewers
joebonrichie - Group Reviewers
Triage Team - Commits
- R2851:1f86b6707eb6: Bump version and remove deprecated JVM argument
Use the seed feature of sbt, which creates a project based on a remote template. Verify that compilation works.
Steps:
- sbt new scala/scala-seed.g8
- cd scala-seed-project/
- sbt run
- This should be printed to the console
[info] Loading project definition from /tmp/scala-seed-project/project [info] Set current project to Hello (in build file:/tmp/scala-seed-project/) [info] Running example.Hello hello
In addition, you can verify that the test are run successfully by executing
sbt test
Diff Detail
Diff Detail
- Repository
- R2851 sbt
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Version 1.0.2 has been released. Additionally, you need to provide a test plan as shown when you first run arc diff
Comment Actions
Hi, thank you for reviewing.
As a new committer for Solus, what do you mean by "provide a test plan ..."? I am updating an existing project.
I guess I should not bump the release version, as no release was made?
Comment Actions
Sorry if I was not clear. When you first run arc diff you get the following template. For the test plan you need to say how you tested the new update. Other than that LGTM.
Bump version and remove deprecated JVM argument Summary: Test plan:
Comment Actions
Where do I put the test plan?
The upstream source release somehow builds as version "1.0.2-SNAPSHOT". The 1.0.1 did not.
Until it is fixed, I think getting 1.0.1 out the door is good. If you agree, I just need where to add this test plan :)
mkdir testdir cd testdir sbt # See that it writes to the console "Getting org.scala-sbt sbt 1.0.2 ..."
Comment Actions
Test plan is part of the commit message.
As far as I understand v.1.0.1 also builds as a snapshot also their download page provides links to the v1.0.2 release. However, I don't use this software so it's up to you :)
Comment Actions
You are correct. The 1.0.1 also builds a snapshot. So do the current version (0.13.5) in Solus. I just tried building 0.13.5, 1.0.0, 1.0.1 and 1.0.2. How I got 1.0.1 working, and how the current version (0.13.5) confuses me.
It seem like I must remove the -SNAPSHOT in the build configuration - is using sed allowed in the build steps? Is most things allowed in the build steps?
Comment Actions
Bump version and remove deprecated JVM argument
Summary:
SBT released version 1.0.2. Removed a jvm argument that made the JVM
print an error message each time the sbt script was run.
Test plan:
Create an empty directory, and run "sbt sbtVersion", should print "[info] 1.0.2".
Steps: 1. mkdir testdir 2. cd testdir 3. sbt sbtVersion 4. Verify that it prints "[info] 1.0.2", in addition to other output.
Signed-off-by: René Vangsgaard <rene.vangsgaard@gmail.com>
Comment Actions
You need to update the original commit message with what you've put as a revision comment.
| package.yml | ||
|---|---|---|
| 14 | As sed is part of system.base you don't need to include it in the builddeps. | |
Comment Actions
- Reviewer feedback: As sed is part of system.base you don't need to include it in the builddeps
Comment Actions
The test plan is not sufficient still. Simply saying xyz --version is not enough, you need test the program against an existing project or create a skeleton project to test the program, somehow give reasonable proof that the program is working as intended.