Differential D10297

Update libnvidia-container to 1.3.1
ClosedPublic
Actions

Authored by xulongwu4 on Sun, Jan 3, 11:00 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

R4611:b99dac95f251: Update libnvidia-container to 1.3.1

Summary

Update libnvidia-container to 1.3.1.

Changelog:

Honor OPT_NO_CGROUPS in nvc_device_mig_caps_mount
Fix bug in resolving absolute symlinks in find_library_paths()
Add support to "list" command to print /dev based capabilities
Add logic to conditionally mount /dev based nvidia-capabilities

Test Plan

Dependency of D10296.

Diff Detail

Repository

R4611 libnvidia-container

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

xulongwu4 created this revision.Sun, Jan 3, 11:00 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSun, Jan 3, 11:00 PM

xulongwu4 requested review of this revision.Sun, Jan 3, 11:00 PM

xulongwu4 added a child revision: D10296: Update nvidia-container-toolkit to 1.4.0.Sun, Jan 3, 11:01 PM

xulongwu4 edited the summary of this revision. (Show Details)Sun, Jan 3, 11:04 PM

JoshStrobl requested changes to this revision.Wed, Jan 6, 2:36 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

pspec_x86_64.xml
25	Basically all of /usr/share/doc can be nuked.

This revision now requires changes to proceed.Wed, Jan 6, 2:36 PM

Nuke /usr/share/doc and fix the description

xulongwu4 marked an inline comment as done.Wed, Jan 6, 10:13 PM

JoshStrobl requested changes to this revision.Fri, Jan 8, 2:55 AM

JoshStrobl retitled this revision from Update libnvida-container to 1.3.1 to Update libnvidia-container to 1.3.1.

JoshStrobl added inline comments.

package.yml
5	Your indentation changed. Should be 4 spaces not 2.

This revision now requires changes to proceed.Fri, Jan 8, 2:56 AM

JoshStrobl added inline comments.Fri, Jan 8, 2:57 AM

package.yml
5	Indentation should be 4 not 2

Fix indentation

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Jan 8, 2:38 PM

Closed by commit R4611:b99dac95f251: Update libnvidia-container to 1.3.1 (authored by xulongwu4, committed by JoshStrobl). · Explain WhyFri, Jan 8, 2:44 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4611:b99dac95f251: Update libnvidia-container to 1.3.1.

Revision Contents
Changeset List

			Path	Packages
M			abi_symbols (6 lines)
D	M		files/use_downloaded_nvidia_modprobe.patch (19 lines)
M			package.yml (20 lines)
M			pspec_x86_64.xml (26 lines)

Diff 24824

abi_symbols

Loading...

files/use_downloaded_nvidia_modprobe.patch

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...