Page MenuHomeSolus
Differential D10250

Add libinstpatch support to fluidsynth
ClosedPublic
Actions

Authored by Jacalz on Dec 29 2020, 4:14 PM.
Tags
None
Referenced Files
F11032543: D10250.id24691.diff
Wed, Aug 9, 2:24 PM
F11032542: D10250.id24642.diff
Wed, Aug 9, 2:24 PM
F11032541: D10250.id.diff
Wed, Aug 9, 2:24 PM
F11032540: D10250.id24712.diff
Wed, Aug 9, 2:24 PM
F11025821: D10250.diff
Wed, Aug 9, 1:25 AM
F10869000: D10250.id24712.diff
Jun 18 2023, 2:04 AM
F10865116: D10250.id24642.diff
Jun 17 2023, 10:25 AM
F10863533: D10250.id24691.diff
Jun 17 2023, 2:49 AM
View All 17 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R773:cd96a16ce0d2: Add libinstpatch support to fluidsynth
Summary

This makes use of the new libinstpatch library to load DLS and GIG files.

Test Plan
  • Tested that fluidsynth worked inside carla.

Diff Detail

Repository
R773 fluidsynth
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Jacalz created this revision.Dec 29 2020, 4:14 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptDec 29 2020, 4:14 PM
Jacalz requested review of this revision.Dec 29 2020, 4:14 PM
JoshStrobl requested changes to this revision.Dec 30 2020, 6:08 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
19

Should use its pkgconfig. It also pulls in sndfile so don't need that anymore either.

This revision now requires changes to proceed.Dec 30 2020, 6:08 PM
Jacalz updated this revision to Diff 24691.Dec 30 2020, 7:57 PM

Use pkgconfig instead

JoshStrobl accepted this revision.Jan 1 2021, 10:42 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 1 2021, 10:42 AM
Closed by commit R773:cd96a16ce0d2: Add libinstpatch support to fluidsynth (authored by Jacalz, committed by JoshStrobl). · Explain WhyJan 1 2021, 10:43 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R773:cd96a16ce0d2: Add libinstpatch support to fluidsynth.

Revision Contents
Changeset List

PathSize
2 lines
7 lines
10 lines

Diff 24642

View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.