Paths

Table of Contentst

Differential D10248

Build qutebrowser using packager Makefile
ClosedPublic
Actions

Authored by Phantop on Dec 28 2020, 11:03 PM.

Tags

None

Referenced Files

	F11046588: D10248.id24713.diff
	Thu, Aug 10, 1:41 PM

	F11046587: D10248.id.diff
	Thu, Aug 10, 1:41 PM

	F11046586: D10248.id24687.diff
	Thu, Aug 10, 1:41 PM

	F11046585: D10248.id24639.diff
	Thu, Aug 10, 1:41 PM

	F11032131: D10248.diff
	Wed, Aug 9, 1:55 PM

	F10920949: D10248.diff
	Jul 9 2023, 10:18 AM

	F10845713: D10248.id24639.diff
	Jun 11 2023, 1:54 AM

	F10842824: D10248.id24687.diff
	Jun 10 2023, 4:04 PM

View All 14 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R2776:6007056a1b2c: Build qutebrowser using packager Makefile

Summary

Results in an optimized build with the addition of some previously not-included scripts and official userscripts.

Its build step is identical to what is currently in package.yml, but the install differs by adding a /usr/share/qutebrowser directory with scripts and userscripts subdirs, builds with the option --optimize=1 and does not include the 96x96 icon Solus includes.

The Makefile is recommended by upstream in the documentation and is used in the official Arch qutebrowser-git pkgbuild.

Test Plan

Open the browser, visit duckduckgo.com, and run the dmenu_qutebrowser userscript

Diff Detail

Repository

R2776 qutebrowser

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Phantop created this revision.Dec 28 2020, 11:03 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 28 2020, 11:03 PM

Phantop requested review of this revision.Dec 28 2020, 11:03 PM

Phantop edited the summary of this revision. (Show Details)Dec 28 2020, 11:05 PM

Phantop edited the summary of this revision. (Show Details)Dec 28 2020, 11:25 PM

Phantop retitled this revision from Build using packager Makefile to Build qutebrowser using packager Makefile.

Phantop edited the summary of this revision. (Show Details)

Otherwise LGTM, I appreciate the patch.

package.yml
27	Honestly can just do PREFIX=/usr, we have no plans on changing the prefix and it's only really there for internal ypkg usage.

This revision now requires changes to proceed.Dec 30 2020, 6:10 PM

Changes %PREFIX% to /usr

LGTM, thanks!

This revision is now accepted and ready to land.Jan 1 2021, 10:43 AM

Closed by commit R2776:6007056a1b2c: Build qutebrowser using packager Makefile (authored by Phantop, committed by JoshStrobl). · Explain WhyJan 1 2021, 10:43 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R2776:6007056a1b2c: Build qutebrowser using packager Makefile.

Revision Contents
Changeset List

Path

Size

14 lines

pspec_x86_64.xml

221 lines

Diff 24713

package.yml

Loading...

pspec_x86_64.xml

Loading...