Page MenuHomeSolus

Build qutebrowser using packager Makefile
ClosedPublic

Authored by Phantop on Dec 28 2020, 11:03 PM.

Details

Summary

Results in an optimized build with the addition of some previously not-included scripts and official userscripts.

Its build step is identical to what is currently in package.yml, but the install differs by adding a /usr/share/qutebrowser directory with scripts and userscripts subdirs, builds with the option --optimize=1 and does not include the 96x96 icon Solus includes.

The Makefile is recommended by upstream in the documentation and is used in the official Arch qutebrowser-git pkgbuild.

Test Plan

Open the browser, visit duckduckgo.com, and run the dmenu_qutebrowser userscript

Diff Detail

Repository
R2776 qutebrowser
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Phantop created this revision.Dec 28 2020, 11:03 PM
Phantop requested review of this revision.Dec 28 2020, 11:03 PM
Phantop edited the summary of this revision. (Show Details)Dec 28 2020, 11:05 PM
Phantop edited the summary of this revision. (Show Details)Dec 28 2020, 11:25 PM
Phantop retitled this revision from Build using packager Makefile to Build qutebrowser using packager Makefile.
Phantop edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Dec 30 2020, 6:10 PM
JoshStrobl added a subscriber: JoshStrobl.

Otherwise LGTM, I appreciate the patch.

package.yml
27

Honestly can just do PREFIX=/usr, we have no plans on changing the prefix and it's only really there for internal ypkg usage.

This revision now requires changes to proceed.Dec 30 2020, 6:10 PM
Phantop updated this revision to Diff 24687.Dec 30 2020, 7:28 PM

Changes %PREFIX% to /usr

JoshStrobl accepted this revision.Jan 1 2021, 10:43 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 1 2021, 10:43 AM
This revision was automatically updated to reflect the committed changes.