Page MenuHomeSolus

Update fpc to 3.2.0
ClosedPublic

Authored by livingsilver94 on Dec 27 2020, 6:29 PM.

Details

Summary

Changelog available in the home page.

Package changes:

  • fpc is now stateless. Users may need to adjust or regenerate their configuration files in $HOME.

Fixes T9404.

Test Plan
  • Built fpc with make local
  • Stateless configuration tested by adding -vl in /etc/fpc.cfg that prints line numbers when building. Without that flag, lines are not printed. This demonstrates fpc is reading the file.
  • Lazarus builds the default GUI project without user configuration needed
  • fppkg install a52 works

Diff Detail

Repository
R838 fpc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Dec 27 2020, 6:29 PM
livingsilver94 requested review of this revision.Dec 27 2020, 6:29 PM
livingsilver94 planned changes to this revision.Dec 27 2020, 6:31 PM

Oops, I forgot to check if the config file is useful or not.

Make it stateless and add a default config file

livingsilver94 edited the test plan for this revision. (Show Details)EditedDec 28 2020, 11:21 PM

Now we may discuss what build flags are a good default, or we may not :P

@JoshStrobl pinging you as you're working on stateless packages. I want you to notice this patch before our work clashes.

Use %make_install macro

Perhaps it's worth testing if the stateless config works fine with lazarus

Thanks @kyrios123.
Lazarus gives

WARNING: include search path does not exist: /home/fabio/Desktop/lib/x86_64-linux
HINT: using config file /usr/share/defaults/fpc/fpc.cfg
ERROR: RTL unit not found: avl_tree.ppu
ERROR: RTL unit not found: zstream.ppu

When testing the compiler flags, so it's using the default config. It also changes the path to /etc/fpc.cfg if I create one. There are some package not found though, I'll try to solve the problem.

Lazarus can now build complex projects, but fppkg cannot install packages yet. After I fix this, fpc should be ready.

livingsilver94 planned changes to this revision.Jan 1 2021, 11:01 AM

Address stuff I didn't understand initially

livingsilver94 edited the test plan for this revision. (Show Details)Jan 2 2021, 8:17 PM
livingsilver94 edited the summary of this revision. (Show Details)
livingsilver94 edited the summary of this revision. (Show Details)
livingsilver94 edited the test plan for this revision. (Show Details)Jan 3 2021, 10:20 AM
JoshStrobl requested changes to this revision.Jan 21 2021, 6:13 PM
JoshStrobl added inline comments.
package.yml
39

Missing install and flags

pspec_x86_64.xml
2693

Can probably just be moved into the main package using split: no. No reason to have a sub-package only for this.

This revision now requires changes to proceed.Jan 21 2021, 6:13 PM
livingsilver94 added inline comments.Jan 21 2021, 9:09 PM
package.yml
39

No, I'm running the samplecfg command here to generate the file.

livingsilver94 edited the summary of this revision. (Show Details)

libsplit: no

JoshStrobl accepted this revision.Jan 27 2021, 10:52 PM

LGTM, thanks!

package.yml
39

Derp.

This revision is now accepted and ready to land.Jan 27 2021, 10:52 PM
This revision was automatically updated to reflect the committed changes.