Page MenuHomeSolus

Update glow to 1.3.0
ClosedPublic

Authored by Siilwyn on Dec 27 2020, 12:12 PM.

Details

Summary

Update to the latest version, introducing tabs for organization and path expansion in config.

Test Plan

Run locally without any arguments, view output.

Diff Detail

Repository
R5103 glow
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Siilwyn created this revision.Dec 27 2020, 12:12 PM
Siilwyn requested review of this revision.Dec 27 2020, 12:12 PM
JoshStrobl requested changes to this revision.Dec 30 2020, 6:34 PM
JoshStrobl added a subscriber: JoshStrobl.

This needs to be built and you need to clone from our source repo.

This revision now requires changes to proceed.Dec 30 2020, 6:34 PM
Siilwyn updated this revision to Diff 24699.Dec 31 2020, 2:00 PM

Update glow to 1.3.0

Summary: Update to the latest version, introducing tabs for organization and path expansion in config.

Test Plan: Run locally without any arguments, view output.

Reviewers: Triage Team, JoshStrobl

Subscribers: JoshStrobl

Differential Revision: https://dev.getsol.us/D10228

Sorry about that, this should be correct now? I added some flags too since I noticed glow -v was returning unkown instead of the correct version.

JoshStrobl requested changes to this revision.Jan 1 2021, 10:45 AM

You need to clone glow from our repo and apply changes on that :)

https://dev.getsol.us/source/glow/

This revision now requires changes to proceed.Jan 1 2021, 10:45 AM
Siilwyn updated this revision to Diff 24716.Jan 1 2021, 11:04 AM

Base on new clone of glow source

JoshStrobl accepted this revision.Jan 1 2021, 11:11 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 1 2021, 11:11 AM
This revision was automatically updated to reflect the committed changes.