Page MenuHomeSolus
Differential D10225

Update pianobar to 2020.11.28
ClosedPublic
Actions

Authored by leandros_adigard on Dec 26 2020, 9:42 PM.
Tags
None
Referenced Files
F11016494: D10225.diff
Sat, Aug 5, 6:15 PM
F10908006: D10225.id.diff
Jul 6 2023, 10:44 PM
F10868255: D10225.id24714.diff
Jun 17 2023, 10:48 PM
F10866072: D10225.id24700.diff
Jun 17 2023, 1:51 PM
F10861961: D10225.id24600.diff
Jun 16 2023, 6:01 PM
F10857076: D10225.diff
Jun 15 2023, 3:11 AM
F10838491: D10225.id24600.diff
Jun 9 2023, 3:10 PM
F10748539: D10225.id.diff
May 15 2023, 9:32 PM
View All 10 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R2426:a65e788d8389: Update pianobar to 2020.11.28
Summary

Changelog:

  • Support changing station modes
  • Allow choosing time format
  • Add optional debug output
Test Plan

Can run the application. Logged in and played several songs from several stations. Only works inside U.S.

Diff Detail

Repository
R2426 pianobar
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

leandros_adigard created this revision.Dec 26 2020, 9:42 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptDec 26 2020, 9:42 PM
leandros_adigard requested review of this revision.Dec 26 2020, 9:42 PM
JoshStrobl requested changes to this revision.Dec 30 2020, 7:10 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
MAINTAINERS.md
4

Random intending should be fixed.

5

Should be just root_directory without |

This revision now requires changes to proceed.Dec 30 2020, 7:10 PM
leandros_adigard updated this revision to Diff 24700.Dec 31 2020, 4:53 PM
  • Remove random indents and remove pipes in MAINTAINERS.md
JoshStrobl accepted this revision.Jan 1 2021, 10:46 AM
JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thanks!

This revision is now accepted and ready to land.Jan 1 2021, 10:46 AM
Closed by commit R2426:a65e788d8389: Update pianobar to 2020.11.28 (authored by leandros_adigard, committed by JoshStrobl). · Explain WhyJan 1 2021, 10:47 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R2426:a65e788d8389: Update pianobar to 2020.11.28.
algent mentioned this in T9453: [RFC] Needs New Maintainer: pianobar.Jan 2 2021, 9:55 PM

Revision Contents
Changeset List

PathSize
5 lines
6 lines
16 lines

Diff 24714

View Options

MAINTAINERS.md

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.