Page MenuHomeSolus

Update libftdi1 to 1.5
ClosedPublic

Authored by livingsilver94 on Dec 18 2020, 10:20 PM.

Details

Summary
  • Implement tc[io]flush methods & deprecate broken purge_buffers methods
    • Please check your code for ftdi_usb_purge_rx_buffer(), ftdi_usb_purge_tx_buffer() and ftdi_usb_purge_buffers() and migrate to the new ftdi_tc[io]flush() methods. Old code will continue to function, but you'll get a deprecation warning during compilation.
  • Add program to test buffer flush (purge) functionality
  • Add kernel driver auto attach/detach. See new AUTO_DETACH_REATACH_SIO_MODULE option
  • Add ftdi_setflowctrl_xonxoff()
  • ftdi_eeprom / eeprom handling:
    • Unify handling of all boolean eeprom flags
    • Add device release number support
    • Add channel_a_driver support for type xxR chips
    • Add support for group0 drive levels on x232H chips
    • Fix handling of high_current_drive parameter
    • Fix inverted handling of VCP driver field for TYPE_R chips
    • New --verbose option for eeprom decode operation
  • Add SPDX license identifiers to the core library & ftdi_eeprom
  • Various cmake file improvements
  • Fix small bugs in error code paths

Fixes T9375.

Test Plan

Successfully built avrdude that depends on it.

Diff Detail

Repository
R3635 libftdi1
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 requested review of this revision.Dec 18 2020, 10:20 PM
livingsilver94 edited the summary of this revision. (Show Details)Dec 18 2020, 10:21 PM
livingsilver94 edited the summary of this revision. (Show Details)
livingsilver94 edited the summary of this revision. (Show Details)Dec 18 2020, 10:37 PM

Let me know if you want to split libftdi1 and libftdipp1.

There are no destructive ABI changes but I think it's safe to rebuild all the revdeps.

JoshStrobl added inline comments.
pspec_x86_64.xml
28

Does it use this config at all or can we nuke it?

Remove example

JoshStrobl accepted this revision.Jan 20 2021, 5:26 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 20 2021, 5:26 PM
This revision was automatically updated to reflect the committed changes.