Page MenuHomeSolus

Initial inclusion of oniguruma
ClosedPublic

Authored by kaktuspalme on Dec 18 2020, 2:17 PM.

Details

Summary

New package required by PHP version 7.4.13

Test Plan

Update PHP against this package.

Diff Detail

Repository
R5123 oniguruma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kaktuspalme created this revision.Dec 18 2020, 2:17 PM
kaktuspalme requested review of this revision.Dec 18 2020, 2:17 PM
kaktuspalme planned changes to this revision.Dec 18 2020, 2:20 PM

I'm not sure if onig-config is really needed. Will remove it if not.

kaktuspalme requested review of this revision.EditedDec 23 2020, 9:40 AM

I'll leave onig-config although I don't know what it's used for / why it's really needed. Other distributions distribute it too.

kaktuspalme edited the summary of this revision. (Show Details)Dec 23 2020, 9:40 AM
kaktuspalme updated this revision to Diff 24508.EditedDec 23 2020, 10:03 AM

Disabled static, shortend summary

Thanks @algent

Shortened setup

kaktuspalme edited the test plan for this revision. (Show Details)Dec 23 2020, 10:10 AM
kaktuspalme edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Dec 23 2020, 5:19 PM
JoshStrobl added a subscriber: JoshStrobl.

You don't have your packager file set up. Check our building a package doc.

This revision now requires changes to proceed.Dec 23 2020, 5:19 PM
kaktuspalme updated this revision to Diff 24542.EditedDec 24 2020, 8:09 AM

Packager info

Edit: File was there but I ran sudo make instead of just make

JoshStrobl accepted this revision.Dec 25 2020, 7:34 AM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 25 2020, 7:34 AM
This revision was automatically updated to reflect the committed changes.