Page MenuHomeSolus
Differential D10167

Initial inclusion of oniguruma
ClosedPublic
Actions

Authored by kaktuspalme on Dec 18 2020, 2:17 PM.
Tags
None
Referenced Files
F10840124: D10167.id24566.diff
Sat, Jun 10, 12:06 AM
F10840013: D10167.id.diff
Fri, Jun 9, 11:39 PM
F10839904: D10167.id24508.diff
Fri, Jun 9, 11:16 PM
F10838276: D10167.diff
Fri, Jun 9, 1:05 PM
F10746823: D10167.diff
Mon, May 15, 12:53 PM
F10712208: D10167.diff
May 1 2023, 4:28 AM
Subscribers
algent
guitar52
JoshStrobl
maximko91

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R5123:fb42963a3bd9: Initial inclusion of oniguruma
Summary

New package required by PHP version 7.4.13

Test Plan

Update PHP against this package.

Diff Detail

Repository
R5123 oniguruma
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kaktuspalme created this revision.Dec 18 2020, 2:17 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptDec 18 2020, 2:17 PM
kaktuspalme requested review of this revision.Dec 18 2020, 2:17 PM
kaktuspalme planned changes to this revision.Dec 18 2020, 2:20 PM

I'm not sure if onig-config is really needed. Will remove it if not.

kaktuspalme mentioned this in D10185: Oniguruma package.Dec 21 2020, 9:56 AM
guitar52 added a subscriber: guitar52.Dec 21 2020, 12:10 PM
kaktuspalme requested review of this revision.EditedDec 23 2020, 9:40 AM

I'll leave onig-config although I don't know what it's used for / why it's really needed. Other distributions distribute it too.

kaktuspalme edited the summary of this revision. (Show Details)Dec 23 2020, 9:40 AM
kaktuspalme updated this revision to Diff 24508.EditedDec 23 2020, 10:03 AM

Disabled static, shortend summary

Thanks @algent

kaktuspalme added a subscriber: algent.Dec 23 2020, 10:04 AM
kaktuspalme updated this revision to Diff 24509.Dec 23 2020, 10:08 AM

Shortened setup

kaktuspalme edited the test plan for this revision. (Show Details)Dec 23 2020, 10:10 AM
kaktuspalme edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Dec 23 2020, 5:19 PM
JoshStrobl added a subscriber: JoshStrobl.

You don't have your packager file set up. Check our building a package doc.

This revision now requires changes to proceed.Dec 23 2020, 5:19 PM
kaktuspalme updated this revision to Diff 24542.EditedDec 24 2020, 8:09 AM

Packager info

Edit: File was there but I ran sudo make instead of just make

JoshStrobl accepted this revision.Dec 25 2020, 7:34 AM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 25 2020, 7:34 AM
Closed by commit R5123:fb42963a3bd9: Initial inclusion of oniguruma (authored by kaktuspalme, committed by JoshStrobl). · Explain WhyDec 25 2020, 7:36 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R5123:fb42963a3bd9: Initial inclusion of oniguruma.
maximko91 added a subscriber: maximko91.Dec 26 2020, 2:10 PM

Revision Contents
Changeset List

PathSize
5 lines
1 line
263 lines
1 line
16 lines
52 lines

Diff 24566

View Options

MAINTAINERS.md

Loading...
View Options

Makefile

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.