Initial packaging of exfatprogs 1.0.4
ClosedPublic
Actions

Authored by silke on Dec 16 2020, 5:00 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T9231: Request for exfatprogs

Commits

R5143:b0744765aa6f: Initial packaging of exfatprogs 1.0.4

Summary

Initial packaging of the official userspace utilities that accompany the kernel support.
These don't actually need the kernel support, but the utilities from fuse-exfat usually take precedence.

Resolves T9231

Test Plan

Format partition using /usr/sbin/mkfs.exfat
Mount, add files and unmount using current fuse implementation.
Change and read the label using /usr/sbin/tune.exfat
Check filesystem using /usr/sbin/fsck.exfat

Diff Detail

Repository

R5143 exfatprogs

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

silke created this revision.Dec 16 2020, 5:00 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 16 2020, 5:00 PM

silke requested review of this revision.Dec 16 2020, 5:00 PM

This is going to end up being the third exFAT file system implementation package we'll have in the library, so I think we need to perform some cleanup instead of just keeping both fuse-exfat and exfat-utils around. I did the kernel enablement linux-current-5.10.5-167 and I don't believe there is any additional enablement we need to do, so mounting of exfat file systems should work OOTB without the need for the mount.* binaries from either of the existing packages.

Remains to be seen if we need the exfatlabel command, maybe worth testing if you can still relabel a exFAT partition or volume with only exfatprogs installed?

Cleanup would involve:

Submitting a solus-sc PR that adds fuse-exfat, fuse-exfat-dbginfo, and exfat-utilsto distribution.xml.in in the repo_data folder, running the ./merged_repos.sh script while in the repo_data folder to generate the distribution.xml file.
Adding replaces for fuse-exfat and exfat-utils to exfatprogs, remove the conflicts.

This revision now requires changes to proceed.Jan 8 2021, 2:37 PM

I don't think we can deprecate exfat-utils just yet. This one is not yet supported by Gnome disks (you can't partition using exfat).

In D10145#169594, @Jacalz wrote:

I don't think we can deprecate exfat-utils just yet. This one is not yet supported by Gnome disks (you can't partition using exfat).

I'm not seeing any indication in the source code that they need exfat-utils directly. In fact, if anything this issue provides clear indication that no changes are actually needed.

In D10145#169595, @JoshStrobl wrote:

In D10145#169594, @Jacalz wrote:

I don't think we can deprecate exfat-utils just yet. This one is not yet supported by Gnome disks (you can't partition using exfat).

I'm not seeing any indication in the source code that they need exfat-utils directly. In fact, if anything this issue provides clear indication that no changes are actually needed.

Tested this, and formatting and relabeling exfat with GNOME Disks doesn't work because the utilities provided by exfat are not supported by udisks (relevant code).

If we really want only a single exfat package, I see the following options:

Wait until exfatprogs is supported by udisks (after a PR or feature request)
Patch udisks with support for exfatprogs (which is a fairly simple patch)
Include compatible wrappers (in two simple bash scripts, for example)

Ah so it's an issue in udisks. Yea looks like patching that would be trivial. Let's do that.

I see, thanks for looking into the issue. Also, fyi, we probably can't deprecate fuse-exfat as it would mean that users of exfat on the LTS kernels have no support for that filesystem.

In D10145#169681, @Jacalz wrote:

I see, thanks for looking into the issue. Also, fyi, we probably can't deprecate fuse-exfat as it would mean that users of exfat on the LTS kernels have no support for that filesystem.

Yeah, that's an issue. Proposal:

Deprecate exfat-utils now.
Patch udisks for exfatprogs.
Deprecate fuse-exfat when LTS has native exfat support.

In D10145#169759, @silke wrote:

In D10145#169681, @Jacalz wrote:

I see, thanks for looking into the issue. Also, fyi, we probably can't deprecate fuse-exfat as it would mean that users of exfat on the LTS kernels have no support for that filesystem.

Yeah, that's an issue. Proposal:

Deprecate exfat-utils now.

Patch udisks for exfatprogs.

Deprecate fuse-exfat when LTS has native exfat support.

Sounds more sensible. Though isn't that going to break the FAT partitioning on udisks for LTS users? Suppose at some point we have to draw a line.

silke mentioned this in D10425: Patch udisks for exfatprogs.Jan 23 2021, 12:02 PM

In D10145#171375, @JoshStrobl wrote:

In D10145#169759, @silke wrote:

In D10145#169681, @Jacalz wrote:

I see, thanks for looking into the issue. Also, fyi, we probably can't deprecate fuse-exfat as it would mean that users of exfat on the LTS kernels have no support for that filesystem.

Yeah, that's an issue. Proposal:

Deprecate exfat-utils now.

Patch udisks for exfatprogs.

Deprecate fuse-exfat when LTS has native exfat support.

Sounds more sensible. Though isn't that going to break the FAT partitioning on udisks for LTS users? Suppose at some point we have to draw a line.