Page MenuHomeSolus
Differential D10143

Update gmusicbrowser to 1.1.16, fixes T9410
ClosedPublic
Actions

Authored by fbg13 on Dec 16 2020, 1:51 PM.
Tags
None
Referenced Files
F10887587: D10143.id25084.diff
Jun 26 2023, 2:13 PM
F10886870: D10143.id24406.diff
Jun 26 2023, 4:19 AM
F10886399: D10143.id24412.diff
Jun 25 2023, 10:16 PM
F10886083: D10143.id24417.diff
Jun 25 2023, 6:30 PM
F10882963: D10143.diff
Jun 23 2023, 9:45 PM
F10750644: D10143.id24412.diff
May 16 2023, 8:46 AM
F10727124: D10143.diff
May 9 2023, 6:03 PM
F10718229: D10143.id.diff
May 5 2023, 1:31 AM
View All 9 Files
Subscribers
algent
JoshStrobl
sangheeta

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R4263:ea9ce463f012: Update gmusicbrowser to 1.1.16, fixes T9410
Summary

Changelog:

  • fix not working with perl >=5.24 (remove 2 superfluous "my")
  • add support for .opus files
  • add option to simplify tree in folder pane
  • add option to ignore articles when sorting
  • fix writing embedded lyrics not working
  • fix error when renaming folder
  • fix crashing on exit
  • fix -tagedit not working when only 1 file
  • fix very wrong bitrate for some ogg files
  • picture finder plugin: update picture sources
  • lyrics plugin: add musixmatch.com source
  • artistinfo plugin: update parsing of artist biography
Test Plan

Played some flac files and all was fine.

Diff Detail

Repository
R4263 gmusicbrowser
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fbg13 created this revision.Dec 16 2020, 1:51 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptDec 16 2020, 1:51 PM
fbg13 requested review of this revision.Dec 16 2020, 1:51 PM
algent added a subscriber: algent.Dec 16 2020, 4:27 PM

hey @fbg13, There is release : 1. You didn't bump properly.

fbg13 updated this revision to Diff 24412.Dec 16 2020, 4:41 PM

Bump release number

algent added a comment.Dec 16 2020, 5:34 PM

I see that you fixed the package.yml file but the change is not reflected in pspec_x86_64.xml file.
What you have to do is to run make again, install the new eopkg file in your system, run make clean and then submit it here. with git commit --amend + arc diff.

fbg13 updated this revision to Diff 24417.Dec 16 2020, 5:41 PM

Add updated pspec_x86_64.xml

JoshStrobl requested changes to this revision.Dec 18 2020, 4:24 AM
JoshStrobl added a subscriber: JoshStrobl.

This changelog should be summarized to the most important items and made into a Markdown list (use - with no whitespace before it).

This revision now requires changes to proceed.Dec 18 2020, 4:24 AM
fbg13 edited the summary of this revision. (Show Details)Dec 18 2020, 10:34 AM
sangheeta added a subscriber: sangheeta.Dec 30 2020, 6:47 AM
JoshStrobl accepted this revision.Jan 20 2021, 11:28 PM
JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thanks!

This revision is now accepted and ready to land.Jan 20 2021, 11:29 PM
JoshStrobl added a comment.Jan 20 2021, 11:29 PM

Also in the future please mark this back as needing review when you are done with changes.

Closed by commit R4263:ea9ce463f012: Update gmusicbrowser to 1.1.16, fixes T9410 (authored by George Florea Banus <fbgmck@gmail.com>, committed by JoshStrobl). · Explain WhyJan 20 2021, 11:30 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R4263:ea9ce463f012: Update gmusicbrowser to 1.1.16, fixes T9410.

Revision Contents
Changeset List

Diff 25084

View Options

files/0001-fix-error-with-perl-5.24.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.