Paths

Table of Contentst

Differential D1014

Initial packaging of keyutils
ClosedPublic
Actions

Authored by silke on Sep 16 2017, 8:52 AM.

Tags

None

Referenced Files

	F11016940: D1014.diff
	Sat, Aug 5, 9:26 PM

	F11007390: D1014.diff
	Tue, Aug 1, 7:12 PM

	F10921666: D1014.id2876.diff
	Jul 9 2023, 2:08 PM

	F10921654: D1014.id.diff
	Jul 9 2023, 2:04 PM

	F10726847: D1014.id2368.diff
	May 9 2023, 2:38 PM

	F10726773: D1014.id2828.diff
	May 9 2023, 12:44 PM

	F10726772: D1014.id2828.diff
	May 9 2023, 12:44 PM

	F10726536: D1014.id2876.diff
	May 9 2023, 8:10 AM

View All 10 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R3783:4f0e684797c8: Initial packaging of keyutils

Summary

The 'keyutils' package includes both the library and the utilities,
as both are required for functionality.

Test Plan

Tested request-key functionality in conjunction with NFS and Kerberos.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

silke created this revision.Sep 16 2017, 8:52 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 16 2017, 8:52 AM

Don't submit patches until something is actually accepted for inclusion, as per our Submitting a Package guidelines.

kyrios123 mentioned this in D1017: Initial version of keyutils.Sep 16 2017, 2:04 PM

JoshStrobl requested changes to this revision.Oct 4 2017, 1:56 PM

JoshStrobl added inline comments.

package.yml
12	That >- shouldn't be there and you should be using our existing package.yml generation. See https://solus-project.com/articles/packaging/packaging-practices/en/#generating-a-package-yml
18	Should use `%libdir%` instead of /usr/lib
pspec_x86_64.xml
41	Static libs need to be disabled.

This revision now requires changes to proceed.Oct 4 2017, 1:56 PM

silke added inline comments.Oct 7 2017, 1:00 PM

package.yml
12	The file was generated with the generator. I added the `>-` to fold/strip the newlines. I'll update it to be `\|` instead.

Update package.yml as discussed, disable static lib and use %libdir% variable.

silke marked 4 inline comments as done.Oct 7 2017, 1:07 PM

JoshStrobl accepted this revision.Oct 9 2017, 11:03 AM

This revision is now accepted and ready to land.Oct 9 2017, 11:03 AM

Closed by commit R3783:4f0e684797c8: Initial packaging of keyutils (authored by silke, committed by JoshStrobl). · Explain WhyOct 9 2017, 11:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

37 lines

2 lines

files/

11 lines

22 lines

pspec_x86_64.xml

60 lines

Diff 2876

Makefile

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

files/keyutils.pc

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...