Page MenuHomeSolus

Initial packaging of keyutils
ClosedPublic

Authored by silke on Sep 16 2017, 8:52 AM.

Details

Summary

The 'keyutils' package includes both the library and the utilities,
as both are required for functionality.

See T4415

Test Plan

Tested request-key functionality in conjunction with NFS and Kerberos.

Diff Detail

Repository
R3783 keyutils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

silke created this revision.Sep 16 2017, 8:52 AM

Don't submit patches until something is actually accepted for inclusion, as per our Submitting a Package guidelines.

JoshStrobl requested changes to this revision.Oct 4 2017, 1:56 PM
JoshStrobl added inline comments.
package.yml
12

That >- shouldn't be there and you should be using our existing package.yml generation. See https://solus-project.com/articles/packaging/packaging-practices/en/#generating-a-package-yml

18

Should use %libdir% instead of /usr/lib

pspec_x86_64.xml
41

Static libs need to be disabled.

This revision now requires changes to proceed.Oct 4 2017, 1:56 PM
silke added inline comments.Oct 7 2017, 1:00 PM
package.yml
12

The file was generated with the generator. I added the >- to fold/strip the newlines. I'll update it to be | instead.

silke updated this revision to Diff 2828.Oct 7 2017, 1:06 PM
silke edited edge metadata.

Update package.yml as discussed, disable static lib and use %libdir% variable.

silke marked 4 inline comments as done.Oct 7 2017, 1:07 PM
JoshStrobl accepted this revision.Oct 9 2017, 11:03 AM
This revision is now accepted and ready to land.Oct 9 2017, 11:03 AM
This revision was automatically updated to reflect the committed changes.