Page MenuHomeSolus
Differential D10130

Initial commit of starship
ClosedPublic
Actions

Authored by Phantop on Dec 13 2020, 9:00 PM.
Tags
None
Referenced Files
F11034549: D10130.id24498.diff
Wed, Aug 9, 4:55 PM
F11034548: D10130.id.diff
Wed, Aug 9, 4:55 PM
F11034546: D10130.id24532.diff
Wed, Aug 9, 4:55 PM
F11034545: D10130.id24348.diff
Wed, Aug 9, 4:55 PM
F11034544: D10130.id24410.diff
Wed, Aug 9, 4:55 PM
F11034543: D10130.id24533.diff
Wed, Aug 9, 4:55 PM
F11034542: D10130.id24349.diff
Wed, Aug 9, 4:55 PM
F11034541: D10130.id24496.diff
Wed, Aug 9, 4:55 PM
View All 23 Files
Subscribers
algent
DataDrake

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8931: Starship shell prompts
Commits
R5113:079750c9afe4: Initial commit of starship
Summary

Fixes T8931

Test Plan

Set as prompt in fish and open a Python git repository.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Phantop created this revision.Dec 13 2020, 9:00 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptDec 13 2020, 9:00 PM
Phantop requested review of this revision.Dec 13 2020, 9:00 PM
Phantop updated this revision to Diff 24349.Dec 13 2020, 9:03 PM
Phantop retitled this revision from Initial commit of starship Fixes T8931 to Initial commit of starship.
Phantop edited the summary of this revision. (Show Details)
Phantop added a task: T8931: Starship shell prompts.

Moved relevant issue to summary

DataDrake requested changes to this revision.Dec 16 2020, 7:03 AM
DataDrake added a subscriber: DataDrake.

Missing MAINTAINERS.md, see: Example

pspec_x86_64.xml
41

If you're going to be a maintainer, this needs to be your real name. No aliases.

This revision now requires changes to proceed.Dec 16 2020, 7:03 AM
Phantop updated this revision to Diff 24410.Dec 16 2020, 4:29 PM

Updates packager name to my real name

Phantop updated this revision to Diff 24496.Dec 21 2020, 4:35 PM
Phantop marked an inline comment as done.

Add MAINTAINERS.md

algent added a subscriber: algent.Dec 21 2020, 5:21 PM

There is only one license, so no need to list it with -. Just make it license : ISC

Phantop updated this revision to Diff 24498.Dec 21 2020, 7:59 PM

List ISC license as single license and not as a list

JoshStrobl accepted this revision.Dec 23 2020, 5:22 PM
JoshStrobl requested changes to this revision.

Looks like this wasn't made against a master branch or isn't a squashed commit? Mind checking via git status and make sure you have initted a git repo via git init

This revision now requires changes to proceed.Dec 23 2020, 5:24 PM
Phantop updated this revision to Diff 24532.Dec 23 2020, 6:31 PM

Make into a git repository

JoshStrobl accepted this revision.Dec 23 2020, 7:12 PM

Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 23 2020, 7:13 PM
Closed by commit R5113:079750c9afe4: Initial commit of starship (authored by Phantop, committed by JoshStrobl). · Explain Why
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R5113:079750c9afe4: Initial commit of starship.

Revision Contents
Changeset List

PathSize
1 line
8 lines
23 lines
44 lines

Diff 24410

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.