Page MenuHomeSolus

Initial commit of ibus-bamboo
AbandonedPublic

Authored by nhubaotruong on Dec 13 2020, 10:37 AM.
Tags
None
Referenced Files
F11004113: D10125.diff
Mon, Jul 31, 10:54 PM
F10987200: D10125.diff
Mon, Jul 24, 4:49 AM
F10983743: D10125.diff
Sun, Jul 23, 3:22 PM
F10944823: D10125.id26755.diff
Sat, Jul 15, 1:23 AM
F10944315: D10125.id.diff
Fri, Jul 14, 10:57 PM
F10903863: D10125.diff
Jul 5 2023, 6:28 PM
F10896163: D10125.id26755.diff
Jul 1 2023, 10:24 PM
F10896160: D10125.diff
Jul 1 2023, 10:23 PM

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Summary

Initial commit of ibus-bamboo.
I have to use master.zip link because the release page currently doesn't have the latest version as seen in other distro.

Test Plan

Tested on Solus KDE, it's working perfectly fine.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

nhubaotruong edited the test plan for this revision. (Show Details)

Initial commit of ibus-bamboo

DataDrake added a subscriber: DataDrake.

See inline comments. Also, missing MAINTAINERS.md, see: Example

package.yml
5

Should be using a versioned tarball from either Tags or Releases.

6

Needs to match SPDX identifiers. In this case, it's up to the developers whether or not it is GPL-3.0-or-later or GPL-3.0-only. You may need to ask if they don't clarify on Github.

9

Despite the fact that this is a plugin for a specific language, the description still needs to be in English. It's fine if you just describe it as something like "IBus plugin for the Vietnamese language".

29

And dependencies in system.base or system.devel do not need to be listed. Dependencies are sorted alphabetically, but pkgconfig entries jump to the top of the list.

34

Please remove unused sections. install is the only required build step.

This revision now requires changes to proceed.Dec 16 2020, 7:13 AM

This is my first package on Solus, thanks for your comments.

This comment was removed by nhubaotruong.
nhubaotruong marked 5 inline comments as done.
This comment was removed by nhubaotruong.

Update sources to github tags link, cleanup package.yml

This revision is now accepted and ready to land.May 14 2021, 1:40 PM

Failed at install phase.

This revision now requires changes to proceed.May 14 2021, 1:47 PM

Fix ibus-bamboo install fail, update to version 0.7.4

JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
35

Should be listed above the x11-xcb pkgconfig. pkgconfigs get sorted before explicit package names and in order 0-9A-Za-z

pspec_x86_64.xml
79

You need to set your email in your packager file.

This revision now requires changes to proceed.Aug 25 2021, 6:29 PM

Are you planning on updating your patch?

Closing due to lack of response.