This is a nice change and thanks for fixing wine build, however I don't think adding wine-32bit as a rundep is a good way to move forward. Wine is a massive piece of code and I don't think every LLMS user wants to download wine when they install LMMS.

In D10112#165856, @Jacalz wrote:

This is a nice change and thanks for fixing wine build, however I don't think adding wine-32bit as a rundep is a good way to move forward. Wine is a massive piece of code and I don't think every LLMS user wants to download wine when they install LMMS.

I tested how Vestige behaves without having Wine installed. Instead of erroring out and telling the user they lack Wine it just freezes for like 10 seconds. That looks very broken to me. That freeze will happen per every VST plugin in a project when you open it. While I agree Wine is massive I also think the software should just work, or at least inform the user what they're missing.

We used -DWANT_VST_NOWINE=1 before to get a round it, see https://dev.getsol.us/R1974:1d4f6e6654dc05c4f086d4c51d4f05cefe3e3d16.

In D10112#165859, @Jacalz wrote:

We used -DWANT_VST_NOWINE=1 before to get a round it, see https://dev.getsol.us/R1974:1d4f6e6654dc05c4f086d4c51d4f05cefe3e3d16.

So are you able to use Windows VSTs that way?

I think all it does is tell LMMS to fail more gracefully if wine isn't installed at runtime. Last time I had a go at it, it was broken and wouldn't build. You have a version that now manages to build. I figured you could test how it behaves with and without wine installed ;)

In D10112#165861, @Jacalz wrote:

I think all it does is tell LMMS to fail more gracefully if wine isn't installed at runtime. Last time I had a go at it, it was broken and wouldn't build. You have a version that now manages to build. I figured you could test how it behaves with and without wine installed ;)

While it fails more gracefully, it refuses to load Windows VSTs at all.