Page MenuHomeSolus

Update python-magic to 0.4.18 and add python3
ClosedPublic

Authored by stalebrim on Dec 8 2020, 8:00 PM.

Details

Summary
Test Plan
  • The module can be now imported successfully in python3 and Lutris
  • Check eopkg still works (including install, uninstall, reinstall, info and search, checked also building a third-party package)

Diff Detail

Repository
R2616 python-magic
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

stalebrim created this revision.Dec 8 2020, 8:00 PM
stalebrim requested review of this revision.Dec 8 2020, 8:00 PM
algent added a subscriber: algent.Dec 8 2020, 8:24 PM

Now you can remove python-setuptools from builddeps.
Any idea why the component is system.base?

stalebrim updated this revision to Diff 24278.Dec 8 2020, 8:28 PM

Remove setuptools

Any idea why the component is system.base?

I have no idea, it was already

livingsilver94 added a subscriber: livingsilver94.EditedDec 8 2020, 8:31 PM

Updating python packages in system.base to Python3 is very, very risky, as packages using them may not list them in rundeps. python-pylzma, for example, is used by eopkg.
Before updating such packages, then, be 100% sure you have tested all the revdeps.

stalebrim abandoned this revision.EditedDec 8 2020, 8:34 PM

Yeah I noticed it borks eopkg. Of course eopkg info doesn't state it as a revdep.

However, python2 version can't be used by Lutris.

Then why don't you add Python3 and keep Python2?

stalebrim updated this revision to Diff 24280.Dec 8 2020, 8:48 PM

Add python3 instead of upgrading to python3

stalebrim edited the test plan for this revision. (Show Details)Dec 8 2020, 8:48 PM
stalebrim retitled this revision from Update python-magic to 0.4.18 and upgrade to Python 3 to Update python-magic to 0.4.18 and add python3.
stalebrim edited the test plan for this revision. (Show Details)Dec 8 2020, 8:57 PM
stalebrim edited the summary of this revision. (Show Details)Dec 8 2020, 9:06 PM
stalebrim edited the summary of this revision. (Show Details)Dec 8 2020, 9:09 PM
JoshStrobl accepted this revision.Dec 9 2020, 4:35 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Dec 9 2020, 4:35 PM
This revision was automatically updated to reflect the committed changes.