Page MenuHomeSolus

Initial inclusion of the glow package
ClosedPublic

Authored by Siilwyn on Dec 2 2020, 10:46 PM.

Details

Summary

Initial inclusion of the glow package.

Resolves T9415

Test Plan

Build the package and ran locally with glow, which shows expected local markdown files.

Diff Detail

Repository
R5103 glow
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Siilwyn created this revision.Dec 2 2020, 10:46 PM
Siilwyn requested review of this revision.Dec 2 2020, 10:46 PM
Siilwyn edited the summary of this revision. (Show Details)Dec 2 2020, 10:48 PM
JoshStrobl edited the summary of this revision. (Show Details)Dec 4 2020, 3:19 PM
JoshStrobl requested changes to this revision.Dec 4 2020, 3:23 PM
JoshStrobl added a subscriber: JoshStrobl.

Congrats on the first patch!

Please include a MAINTAINERS.md file with the following content, replacing the relevant REPLACEME bits:

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- REPLACEME FIRST NAME(S) LAST NAME(S)
  - IRC: REPLACEME
  - Email: REPLACEME
package.yml
10

Let's have the following be the summary instead:

Glow is a terminal based markdown reader designed from the ground up to bring out the beauty—and power—of the CLI.

This revision now requires changes to proceed.Dec 4 2020, 3:23 PM
Siilwyn updated this revision to Diff 24260.Dec 5 2020, 3:32 PM

Include maintainers file and expand description as suggested by reviewer JoshStrobl.

JoshStrobl accepted this revision.Dec 9 2020, 4:29 PM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 9 2020, 4:29 PM
This revision was automatically updated to reflect the committed changes.