Page MenuHomeSolus

Update rubberband to 1.9
ClosedPublic

Authored by aleksvor on Nov 30 2020, 5:43 PM.

Details

Summary

Changelog:

  • Fix incorrect numbering of pitch speed/quality flags in the auxiliary C wrapper header. The effect of this was that code using the C wrapper that intended to select the higher-quality pitch-shift mode was actually choosing the higher-speed mode, and vice versa.
  • Improve error handling in command-line utility.
  • Fix some compiler warnings.
  • Install the JNI target (with make install) only if it has actually been built, avoiding an error otherwise.
Test Plan

Played back audio file in mpv using mpv --af=rubberband and checked pitch shifting at different playback speeds.

Diff Detail

Repository
R2831 rubberband
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Nov 30 2020, 5:43 PM
aleksvor requested review of this revision.Nov 30 2020, 5:43 PM
DataDrake accepted this revision.Dec 15 2020, 9:49 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 15 2020, 9:49 AM
This revision was automatically updated to reflect the committed changes.