Page MenuHomeSolus

Update pipewire to 0.3.16
ClosedPublic

Authored by YakoYakoYokuYoku on Nov 24 2020, 5:41 PM.

Details

Summary

Changelog:

  • Fix screensharing for old 0.2 clients.
  • Many pulse-server improvements. There is now a pipewire-pulse binary that is the prefered solution for PulseAudio compatibility. The replacement libpulse libraries are now deprecated. This also makes audio in Flatpak work.
  • Fix cleanup of listeners everywhere. Force remove of listeners in _destroy to avoid crashes.
  • Add support for a journald logger module.
  • Various memory leak fixes.
  • Silence some warnings that spammed the logs.
  • Fix flush in pw_stream. This fixes small glitches when switching streams in music players.
  • Fix some crashes when destroying objects.
  • Reload the ALSA configuration when creating a node so that hotplugged devices work in all cases.
  • Fix memory leaks in ACP library. This also fixes issues where the mixer device was not closed.
  • Bluetooth now has support for the mSBC codec for SCO source and sink.
  • Many introspection and compatibility improvements. It should now be as good or better than the replacement library.
  • Implement sample cache to make notification events work.
  • Handle errors when linking, fixes jack_connect hang when the ports were already linked.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Started the pipewire and pipewire-pulse services, played a Matroska audio file with mpv, compiled and ran a PipeWire .mp3 file playback program with success.

Diff Detail

Repository
R4226 pipewire
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Nov 24 2020, 5:41 PM
JoshStrobl requested changes to this revision.Nov 24 2020, 5:46 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
6

This is unacceptable. You're basically trying to shoehorn a utility that hasn't been updated in 12 years into pipewire just for the sake of building its man pages, something which isn't required for the use of pipewire. This is something that should've been requested as a package separately, in which it would've been rejected for being DOA.

This revision now requires changes to proceed.Nov 24 2020, 5:46 PM
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Remove manpage generation and validated more testing

YakoYakoYokuYoku marked an inline comment as done.Nov 24 2020, 6:52 PM

I'll probably submit a MR for changing the xmltoman format into another one that is more up to date.

JoshStrobl accepted this revision.Nov 24 2020, 8:02 PM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 24 2020, 8:02 PM
This revision was automatically updated to reflect the committed changes.