Page MenuHomeSolus

samba: patch missing include in libsmbclient.h & update documentation
ClosedPublic

Authored by aleksvor on Nov 22 2020, 6:14 PM.

Details

Summary

This patch is backported from Samba 4.13 series - without this include FFmpeg cannot be compiled against libsmbclient.
Updated documentation about dropped "direct" SMB support in mpv and enablement in FFmpeg.

Test Plan

Built ffmpeg against it and checked that mpv smb://remote-file with mpv 0.33 works again.

Diff Detail

Repository
R2842 samba
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Nov 22 2020, 6:14 PM
aleksvor requested review of this revision.Nov 22 2020, 6:14 PM
aleksvor updated this revision to Diff 24069.Nov 23 2020, 8:07 AM

Patch missing include in libsmbclient.h - required to build ffmpeg against libsmbclient.

aleksvor retitled this revision from samba: update documentation regarding mpv to samba: patch missing include in libsmbclient.h & update documentation.Nov 23 2020, 8:10 AM
aleksvor edited the summary of this revision. (Show Details)
aleksvor edited the test plan for this revision. (Show Details)
aleksvor removed a parent revision: D10020: Update mpv to 0.33.0.
aleksvor added a subscriber: ermo.

Requesting review from @ermo as principal maintainer of Samba.

JoshStrobl accepted this revision.Nov 23 2020, 2:18 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Nov 23 2020, 2:18 PM
ermo added a comment.Nov 26 2020, 10:57 PM

@aleksvor Thanks for getting this sorted and especially for being kind enough to update the documentation! \o/

@JoshStrobl : Thanks for landing this. =)