samba: patch missing include in libsmbclient.h & update documentation
ClosedPublic
Actions

Authored by aleksvor on Nov 22 2020, 6:14 PM.

Details

Reviewers

ermo
JoshStrobl

Group Reviewers

Triage Team

Commits

R2842:afbf175a1605: samba: patch missing include in libsmbclient.h & update documentation

Summary

This patch is backported from Samba 4.13 series - without this include FFmpeg cannot be compiled against libsmbclient.
Updated documentation about dropped "direct" SMB support in mpv and enablement in FFmpeg.

Test Plan

Built ffmpeg against it and checked that mpv smb://remote-file with mpv 0.33 works again.

Diff Detail

Repository

R2842 samba

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aleksvor created this revision.Nov 22 2020, 6:14 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 22 2020, 6:14 PM

aleksvor requested review of this revision.Nov 22 2020, 6:14 PM

Patch missing include in libsmbclient.h - required to build ffmpeg against libsmbclient.

aleksvor retitled this revision from samba: update documentation regarding mpv to samba: patch missing include in libsmbclient.h & update documentation.Nov 23 2020, 8:10 AM

aleksvor edited the summary of this revision. (Show Details)

aleksvor edited the test plan for this revision. (Show Details)

aleksvor removed a parent revision: D10020: Update mpv to 0.33.0.

aleksvor added a child revision: D10023: ffmpeg: enable SMB support for mpv.Nov 23 2020, 8:13 AM