The patch looks good, but I'm not seeing a test plan for this. Please add one (you should be prompted to during arc diff), and validate (test) this mono upgrade against keepass, openra, and pinta. I'm not particularly concerned about nuget, so don't worry about that one.

This revision now requires changes to proceed.May 12 2017, 4:43 PM

Added test plan for this patch.

That didn't actually update the test plan field (not your fault, I just discovered it too when doing a test Arc diff for PHP). Could you try using arc diff --verbatim please? Looking through Arcanist documentation and seeing if there are bits that we should document for the Help Center =)

No problem Josh. Let me see what I can do.

When I do arc diff ----verbatim, I just get what is shown in the attached picture.

Which the normal update differential thing. That from what I have been able to tell just adds a comment to the differential.

Which I guess is not what you are looking for.

Hmm, according to https://secure.phabricator.com/T9110 arc diff --edit --verbatim might work? I appreciate the help!

Hopefully this has updated the test plan section.

In D100#1274, @RaspberryRye wrote:

Hopefully this has updated the test plan section.

It did, fantastic. Thank you for your help and the willingness to test. The patch looks good. I'll get it landed in a moment and update the Help Center article too.

This revision is now accepted and ready to land.May 12 2017, 7:00 PM