Page MenuHomeSolus

Update mono to 4.8.1.0
ClosedPublic

Authored by RaspberryRye on May 12 2017, 2:04 PM.

Details

Summary

Update from 4.6.2 to 4.8.1.0 for applications that need the lastest version of mono.

Test Plan

Have tested update with KeepassXC, OpenRA, and Pinta image
editor. All applications launch and work fine with this version of mono.

Diff Detail

Repository
R2091 mono
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

RaspberryRye created this revision.May 12 2017, 2:04 PM
JoshStrobl requested changes to this revision.May 12 2017, 4:43 PM
JoshStrobl added a subscriber: JoshStrobl.

The patch looks good, but I'm not seeing a test plan for this. Please add one (you should be prompted to during arc diff), and validate (test) this mono upgrade against keepass, openra, and pinta. I'm not particularly concerned about nuget, so don't worry about that one.

This revision now requires changes to proceed.May 12 2017, 4:43 PM
RaspberryRye updated this revision to Diff 180.May 12 2017, 4:59 PM
RaspberryRye edited edge metadata.

Added test plan for this patch.

That didn't actually update the test plan field (not your fault, I just discovered it too when doing a test Arc diff for PHP). Could you try using arc diff --verbatim please? Looking through Arcanist documentation and seeing if there are bits that we should document for the Help Center =)

No problem Josh. Let me see what I can do.

When I do arc diff ----verbatim, I just get what is shown in the attached picture.

Which the normal update differential thing. That from what I have been able to tell just adds a comment to the differential.

Which I guess is not what you are looking for.

JoshStrobl added a comment.EditedMay 12 2017, 6:53 PM

Hmm, according to https://secure.phabricator.com/T9110 arc diff --edit --verbatim might work? I appreciate the help!

RaspberryRye updated this revision to Diff 185.May 12 2017, 6:58 PM
RaspberryRye edited the test plan for this revision. (Show Details)

Hopefully this has updated the test plan section.

JoshStrobl accepted this revision.May 12 2017, 7:00 PM

Hopefully this has updated the test plan section.

It did, fantastic. Thank you for your help and the willingness to test. The patch looks good. I'll get it landed in a moment and update the Help Center article too.

This revision is now accepted and ready to land.May 12 2017, 7:00 PM

KeepassXC

Btw, Keepass is Mono. KeepassXC is Qt.

Closed by commit R2091:35ce372fbc77: Update mono to 4.8.1.0 (authored by Kayla Manchette <k.manchette1@email.com>, committed by JoshStrobl). · Explain WhyMay 12 2017, 7:03 PM
This revision was automatically updated to reflect the committed changes.

You're very welcome Josh!

Btw, Keepass is Mono. KeepassXC is Qt.

I did not realize we had both. I will keep that in mind.